fix: use rust-embed for DSL files#212
Closed
kevaundray wants to merge 1 commit intoleanEthereum:mainfrom
Closed
Conversation
kevaundray
force-pushed
the
kw/rust-embed-src-code
branch
from
7b5b674 to
350e5b0
Compare
TomWambsgans
added a commit
that referenced
this pull request
May 6, 2026
…native to #212 Co-authored-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Collaborator
|
Hi ;) would the following fix your issue: ? |
TomWambsgans
added a commit
that referenced
this pull request
May 6, 2026
* move rec_aggregation .py files into zkdsl_implem/ * embedd zk_dsl files in `rec_aggregation` crate into the binary. Alternative to #212 Co-authored-by: Kevaundray Wedderburn <kevtheappdev@gmail.com> --------- Co-authored-by: Tom Wambsgans <TomWambsgans@users.noreply.github.com> Co-authored-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
env!is evaluated at build time, so for example if we compile the crate into static libraries, the path to the DSL files will be hardcoded into the binary. This will be something like/user/tom/leanMultiSig/main.py. This is usually okay for local development, however when we want to package this so that we can use it in Python, the path will be fetched at runtime.Potential solutions
There are two solutions that I know of for solving this:
This PR goes with the second option, by embedding the dsl files into the binary with
rust-embedand then creating a path to them at runtime when needed. This means that users of this library will not need to worry about supplying a path to the main.py file.